sockmap: some performance optimizations #2854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: 34ba23b |
|
Master branch: 0738599 |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
1323501
to
c6f886c
Compare
|
Master branch: d252a4a |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
c6f886c
to
6854315
Compare
|
Master branch: 33fc250 |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
6854315
to
2cda987
Compare
|
Master branch: dd642cc |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
2cda987
to
b8b4952
Compare
|
Master branch: f4fd706 |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
b8b4952
to
d68469d
Compare
|
Master branch: aa1b02e |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
d68469d
to
ac4acac
Compare
|
Master branch: 0f86199 |
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
ac4acac
to
cbacc79
Compare
This patch inroduces tcp_read_skb() based on tcp_read_sock(), a preparation for the next patch which actually introduces a new sock ops. TCP is special here, because it has tcp_read_sock() which is mainly used by splice(). tcp_read_sock() supports partial read and arbitrary offset, neither of them is needed for sockmap. Cc: Eric Dumazet <edumazet@google.com> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Currently both splice() and sockmap use ->read_sock() to read skb from receive queue, but for sockmap we only read one entire skb at a time, so ->read_sock() is too conservative to use. Introduce a new proto_ops ->read_skb() which supports this sematic, with this we can finally pass the ownership of skb to recv actors. For non-TCP protocols, all ->read_sock() can be simply converted to ->read_skb(). Cc: Eric Dumazet <edumazet@google.com> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
|
Master branch: 68477ed |
added 2 commits
April 13, 2022 13:02
With ->read_skb() now we have an entire skb dequeued from receive queue, now we just need to grab an addtional refcnt before passing its ownership to recv actors. And we should not touch them any more, particularly for skb->sk. Fortunately, skb->sk is already set for most of the protocols except UDP where skb->sk has been stolen, so we have to fix it up for UDP case. Cc: Eric Dumazet <edumazet@google.com> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
We always allocate skmsg with kzalloc(), so there is no need to call memset(0) on it, the only thing we need from sk_msg_init() is sg_init_marker(). So introduce a new helper which is just kzalloc()+sg_init_marker(), this saves an unncessary memset(0) for skmsg on fast path. Cc: John Fastabend <john.fastabend@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Jakub Sitnicki <jakub@cloudflare.com> Signed-off-by: Cong Wang <cong.wang@bytedance.com>
kernel-patches-bot
force-pushed
the
series/630798=>bpf-next
branch
from
cbacc79
to
498093d
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=630798 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: sockmap: some performance optimizations
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=630798