Fix cgroup attach flags being assigned to effective progs #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: b979f00 |
|
Master branch: 92ec1cc |
kernel-patches-bot
force-pushed
the
series/669445=>bpf-next
branch
from
2294a3b
to
375964b
Compare
Attach flags is only valid for attached progs of this layer cgroup, but not for effective progs. We know that the attached progs is at the beginning of the effective progs array, so we can just populate the elements in front of the prog_attach_flags array. Signed-off-by: Pu Lehui <pulehui@huawei.com>
When root-cgroup attach multi progs and sub-cgroup attach a
override prog, bpftool will display incorrectly for the attach
flags of the sub-cgroup’s effective progs:
$ bpftool c t /sys/fs/cgroup effective
CgroupPath
ID AttachType AttachFlags Name
/sys/fs/cgroup
6 sysctl multi sysctl_tcp_mem
13 sysctl multi sysctl_tcp_mem
/sys/fs/cgroup/cg1
20 sysctl override sysctl_tcp_mem
6 sysctl override sysctl_tcp_mem
13 sysctl override sysctl_tcp_mem
Attach flags is only valid for attached progs of this layer
cgroup, but not for effective progs. Since prog_attach_flags
array is already bypass the effective progs, so we can just
use it.
Signed-off-by: Pu Lehui <pulehui@huawei.com>
|
Master branch: 92ec1cc |
kernel-patches-bot
force-pushed
the
series/669445=>bpf-next
branch
from
375964b
to
74365c4
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=669445 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Fix cgroup attach flags being assigned to effective progs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=669445