Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of small refactorings of BPF program call sites #3634

Closed
wants to merge 4 commits into from

Conversation

kernel-patches-bot
Copy link

Pull request for series with
subject: A couple of small refactorings of BPF program call sites
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232

@kernel-patches-bot
Copy link
Author

Master branch: 274052a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 2786bcf
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 1e660f7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 028a964
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 53e80a3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 9fad7fe
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: cc48755
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: b239da3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 665f5d3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 2fae677
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: cf7de6a
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 57c92f1
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: b8c62fe
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: f7c946f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 1bfe26f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: 47e34cb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: a02c118
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

Kernel Patches Daemon and others added 4 commits September 16, 2022 13:25
Move the received_rps counter value next to the other RPS-related members
in softnet_data. This closes two four-byte holes in the structure, making
room for another pointer in the first two cache lines without bumping the
xmit struct to its own line.

Reviewed-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Song Liu <song@kernel.org>
For queueing packets in XDP we want to add a new redirect map type with
support for 64-bit indexes. To prepare fore this, expand the width of the
'key' argument to the bpf_redirect_map() helper. Since BPF registers are
always 64-bit, this should be safe to do after the fact.

Reviewed-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Song Liu <song@kernel.org>
BPF ABI always uses 64-bit return value, but so far __bpf_prog_run and
higher level wrappers always truncated the return value to 32-bit. We want
to be able to introduce a new BPF program type that returns a PTR_TO_BTF_ID
or NULL from the BPF program to the caller context in the kernel. To be
able to use this returned pointer value, the bpf_prog_run invocation needs
to be able to return a 64-bit value, so update the definitions to allow
this.

To avoid code churn in the whole kernel, we let the compiler handle
truncation normally, and allow new call sites to utilize the 64-bit
return value, by receiving the return value as a u64.

Reviewed-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Song Liu <song@kernel.org>
@kernel-patches-bot
Copy link
Author

Master branch: bfeb7e3
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: ceea991
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
version: 2

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/netdevbpf/list/?series=674232
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am -3
  stdout: 'Applying: dev: Move received_rps counter next to RPS members in softnet data
Applying: bpf: Expand map key argument of bpf_redirect_map to u64
Applying: bpf: Use 64-bit return value for bpf_prog_run
Patch failed at 0003 bpf: Use 64-bit return value for bpf_prog_run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".'
  stderr: 'error: sha1 information is lacking or useless (include/linux/bpf.h).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch'

conflict:


@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=674232 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants