xsk: fix destination buffer address when copying with metadata #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 07ec7b5 |
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
d2d4fa2
to
9588f70
Compare
|
Upstream branch: aa3496a |
kernel-patches-bot
force-pushed
the
series/691907=>bpf-next
branch
from
2899137
to
28e1922
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
9588f70
to
816772e
Compare
|
Upstream branch: af085f5 |
kernel-patches-bot
force-pushed
the
series/691907=>bpf-next
branch
from
28e1922
to
a0bcfe7
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
816772e
to
5d1b61c
Compare
|
Upstream branch: db55911 |
kernel-patches-bot
force-pushed
the
series/691907=>bpf-next
branch
from
a0bcfe7
to
a60be2f
Compare
kernel-patches-bot
force-pushed
the
bpf-next_base
branch
from
5d1b61c
to
e869fb9
Compare
|
Upstream branch: f71b2f6 |
While working on a simplified test for [0] it occurred to me that the following looks fishy: data = xsk_umem__get_data(xsk->umem_area, rx_desc->addr); data_meta = data - sizeof(my metadata); Since the data points to umem frame at addr X, data_mem points to the end of umem frame X-1. I don't think it's by design? 0: https://lore.kernel.org/bpf/20221028181431.05173968@kernel.org/T/#t Cc: Björn Töpel <bjorn@kernel.org> Cc: Magnus Karlsson <magnus.karlsson@intel.com> Cc: Maciej Fijalkowski <maciej.fijalkowski@intel.com> Cc: Jonathan Lemon <jonathan.lemon@gmail.com> Signed-off-by: Stanislav Fomichev <sdf@google.com>
kernel-patches-bot
force-pushed
the
series/691907=>bpf-next
branch
from
a60be2f
to
463c7ad
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=691907 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: xsk: fix destination buffer address when copying with metadata
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=691907