bpf: Fix d_path test after last fs update #5600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
Recent commit [1] broken d_path test, because now filp_close is not called directly from sys_close, but eventually later when the file is finally released. I can't see any other solution than to hook filp_flush function and that also means we need to add it to btf_allowlist_d_path list, so it can use the d_path helper. But it's probably not very stable because filp_flush is static so it could be potentially inlined. Also if we'd keep the current filp_close hook and find a way how to 'wait' for it to be called so user space can go with checks, then it looks like d_path might not work properly when the task is no longer around. thoughts? jirka [1] 021a160 ("fs: use __fput_sync in close(2)")
|
Upstream branch: 2e29df8 |
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=780464 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Fix d_path test after last fs update
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=780464