Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Fix BTF_ID symbol generation #5686

Closed
wants to merge 1 commit into from

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: bpf: Fix BTF_ID symbol generation
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=784545

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 6bd5bcb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=784545
version: 1

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 837723b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=784545
version: 1

Marcus and Nick reported issue where BTF_ID macro generates same
symbol in separate objects and that breaks final vmlinux link.

Adding __LINE__ number suffix to make BTF_ID symbol more unique,
which is not real fix, but it would help for now and meanwhile
we can work on better solution as suggested by Andrii in [2].

[1] ClangBuiltLinux/linux#1913
[2] https://lore.kernel.org/bpf/ZQQVr35crUtN1quS@krava/T/#m64d7c29c407d6adf0e7b420359958b3aafa7bf69
Reported-by: Marcus Seyfarth <m.seyfarth@gmail.com>
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@kernel-patches-daemon-bpf
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=784545 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant