bpf: avoid uninitialized warnings in verifier_global_subprogs.c #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 329a672 |
|
Upstream branch: 329a672 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851216=>bpf-next
branch
from
29887c3
to
13e181f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
459d932
to
ba083f5
Compare
|
Upstream branch: 75b0fbf |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851216=>bpf-next
branch
from
13e181f
to
7700834
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
ba083f5
to
20150dc
Compare
|
Upstream branch: 93d1c2d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851216=>bpf-next
branch
from
7700834
to
9408b38
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
20150dc
to
606f72a
Compare
|
Upstream branch: 7e2c7a3 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851216=>bpf-next
branch
from
9408b38
to
941ed55
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
606f72a
to
041b1be
Compare
|
Upstream branch: e612b5c |
[Changes from V1:
- The warning to disable is -Wmaybe-uninitialized, not -Wuninitialized.
- This warning is only supported in GCC.]
The BPF selftest verifier_global_subprogs.c contains code that
purposedly performs out of bounds access to memory, to check whether
the kernel verifier is able to catch them. For example:
__noinline int global_unsupp(const int *mem)
{
if (!mem)
return 0;
return mem[100]; /* BOOM */
}
With -O1 and higher and no inlining, GCC notices this fact and emits a
"maybe uninitialized" warning. This is by design. Note that the
emission of these warnings is highly dependent on the precise
optimizations that are performed.
This patch adds a compiler pragma to verifier_global_subprogs.c to
ignore these warnings.
Tested in bpf-next master.
No regressions.
Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Cc: david.faust@oracle.com
Cc: cupertino.miranda@oracle.com
Cc: Yonghong Song <yonghong.song@linux.dev>
Cc: Eduard Zingerman <eddyz87@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/851216=>bpf-next
branch
from
941ed55
to
5495437
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
041b1be
to
63334d2
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=851308 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: avoid uninitialized warnings in verifier_global_subprogs.c
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=851216