Add flowchart about the status ownership and mention "running" around the absent status #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
spbnick
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Looks good to me mostly, thank you very much, Tales!
I left a couple comments inline, and do you think you could add a lead-in to that diagram, in a separate paragraph? Something like "Another way to organize status values is to put them into an execution outcome chart:"
added 2 commits
June 7, 2024 16:58
In addition to the table covering the statuses, add a flowchart to summarize the ownership of each status. Use mermaid's "block-beta" instead of "flowchart" to render a grid-like chart, with vertical arrows pointing in both directions. Signed-off-by: Tales da Aparecida <tales.aparecida@redhat.com>
In addition to "scheduled", there's a consensus that the absent status can also mean "running", because it would be too resource intensive to track each running test, both to KCIDB and the runners. Signed-off-by: Tales da Aparecida <tales.aparecida@redhat.com>
tales-aparecida
force-pushed
the
add-picture
branch
from
aa880fc
to
328d6fd
Compare
|
Thanks a lot, Tales! Merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKI had this chart for a while in https://cki-project.org/docs/test-maintainers/status-meaning/ and it's been useful for explaining ownership!