Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Creation of buster-xfstests rootfs #230

Closed
wants to merge 1 commit into from

Conversation

Lakshmipathi
Copy link

Modified rootfs.yaml to accept crush_image_options,multiple_partition as optional parameters.
Added xfstests rootfs build script and jpl template file.

Signed-off-by: Lakshmipathi.G lakshmipathi.ganapathi@collabora.com

@gctucker gctucker requested a review from a team November 4, 2019 20:45
Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good starting point but there are a few things that need to be improved.

jenkins/debian/debos/rootfs.yaml Outdated Show resolved Hide resolved
jenkins/debian/debos/rootfs.yaml Outdated Show resolved Hide resolved
jenkins/debian/debos/scripts/buster-xfstests.sh Outdated Show resolved Hide resolved
jenkins/debian/debos/scripts/buster-xfstests.sh Outdated Show resolved Hide resolved
jenkins/debian/debos/scripts/buster-xfstests.sh Outdated Show resolved Hide resolved
@Lakshmipathi
Copy link
Author

@gctucker please review recent changes.

@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Nov 20, 2019
@gctucker gctucker changed the title Creation of buster-xfstests rootfs WIP - Creation of buster-xfstests rootfs Dec 20, 2019
@gctucker
Copy link
Contributor

This needs to be rebased now that #221 has been merged.

@gctucker
Copy link
Contributor

gctucker commented Jan 2, 2020

@Lakshmipathi We need only one PR, force-pushing to this one is fine and helps with keeping the review history. What is #292 for?

Added xfstests rootfs build script and jpl template file.
Added test overlay script to setup xfstests config file.
Updated RootFS.groovy to pass crush_image_options parameters.

Signed-off-by: Lakshmipathi.G <lakshmipathi.ganapathi@collabora.com>
@Lakshmipathi
Copy link
Author

okay reverted few commits and force-pushed required changes. Will close #292

@gctucker gctucker removed the staging-skip Don't test automatically on staging.kernelci.org label Jan 6, 2020
@gctucker gctucker added the staging-skip Don't test automatically on staging.kernelci.org label Jan 24, 2020
@gctucker
Copy link
Contributor

Let's get the kci_rootfs changes merged and then revisit this PR to use the new YAML configuration.

@gctucker gctucker linked an issue Jul 1, 2020 that may be closed by this pull request
8 tasks
@gctucker gctucker mentioned this pull request Oct 5, 2020
8 tasks
@gctucker
Copy link
Contributor

gctucker commented Oct 5, 2020

A new PR should be made using kci_rootfs, with Debian Buster.

@gctucker gctucker closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-skip Don't test automatically on staging.kernelci.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fstests
2 participants