kselftest: Add new option -E for specifying environment variables #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazoes
requested review from
padovan,
nuclearcat,
pawiecz,
JenySadadia,
laura-nao and
nfraprado
|
This change should be done on the upstream project, https://github.com/Linaro/test-definitions, seeing as this fork is in sync with upstream, so we can keep it that way :). |
|
@nfraprado yes, makes sense. I'll open up a PR there |
|
Reopening to give it a spin on staging. If upstream maintainers pull this change soon I'll close the PR (after |
|
Thanks @pawiecz |
|
@crazoes great to see your changes merged upstream 🎉 If you'd need to verify new test definitions before branch sync, you can always temporarily switch kselftest revision to staging so you're not blocked by downstream repo falling behind. |
|
@pawiecz that's good to know. Thank you for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are not able to run the subtests of a kselftest due to lack of support for passing the parameters to the test case. Hence, solve this problem by adding support for passing environment variables in KernelCI kselftest.