Part 7 - Add Google Auth Provider #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kernwig
commented
Jan 12, 2020
kernwig
commented
- Added federated login with Google
- Added CloudFront hosting, needed to have https endpoint.
- Detect production vs dev and use correct OAuth redirect URLs
- Updated service work configuration for new file output of Angular 8.
- Detect federated sign-in and redirect user to account page.
- This fixes bug of sign-in not being detected - landing on the account page triggers Auth.authStateChange$
- See Sign in user & get user object - Facebook & Google Login - AWS Amplify + React Native aws-amplify/amplify-js#4621
- Remove team-provider-info.json from source control. It contains secrets and is environment specific.
- Bug fix: don't override provided storage location when saving.
- Fix: Deploy production build of front-end
- Fix: Force change detection cycle after opening the error modal.
added 5 commits
December 22, 2019 16:31
- Added federated login with Google
- Remove team-provider-info.json from source control. It contains secrets and is environment specific.
- Bug fix: don't override provided storage location when saving.
- Added CloudFront hosting, needed to have https endpoint. - Detect production vs dev and use correct OAuth redirect URLs - Updated service work configuration for new file output of Angular 8. - Fix: Initial state upon login was dereferencing an undefined. - Fix: Deploy production build of front-end - Fix: Force change detection cycle after opening the error modal.
- Detect federated sign-in and redirect user to account page. - This fixes bug of sign-in not being detected - landing on the account page triggers Auth.authStateChange$ - See aws-amplify/amplify-js#4621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.