Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 7 - Add Google Auth Provider #13

Merged
merged 5 commits into from Jan 12, 2020
Merged

Part 7 - Add Google Auth Provider #13

merged 5 commits into from Jan 12, 2020

Conversation

@kernwig
Copy link
Owner

kernwig commented Jan 12, 2020

  • Added federated login with Google
  • Added CloudFront hosting, needed to have https endpoint.
  • Detect production vs dev and use correct OAuth redirect URLs
  • Updated service work configuration for new file output of Angular 8.
  • Detect federated sign-in and redirect user to account page.
    • This fixes bug of sign-in not being detected - landing on the account page triggers Auth.authStateChange$
    • See aws-amplify/amplify-js#4621
  • Remove team-provider-info.json from source control. It contains secrets and is environment specific.
  • Bug fix: don't override provided storage location when saving.
  • Fix: Deploy production build of front-end
  • Fix: Force change detection cycle after opening the error modal.
Adam Fanello added 5 commits Dec 23, 2019
- Added federated login with Google
- Remove team-provider-info.json from source control. It contains secrets and is environment specific.
- Bug fix: don't override provided storage location when saving.
- Added CloudFront hosting, needed to have https endpoint.
- Detect production vs dev and use correct OAuth redirect URLs
- Updated service work configuration for new file output of Angular 8.
- Fix: Initial state upon login was dereferencing an undefined.
- Fix: Deploy production build of front-end
- Fix: Force change detection cycle after opening the error modal.
- Detect federated sign-in and redirect user to account page.
- This fixes bug of sign-in not being detected - landing on the account page triggers Auth.authStateChange$
- See aws-amplify/amplify-js#4621
@kernwig kernwig self-assigned this Jan 12, 2020
@kernwig kernwig merged commit a355ed4 into develop Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.