Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add loadBalancerIP to service spec #30

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

pdemagny
Copy link
Contributor

@pdemagny pdemagny commented Mar 12, 2024

What changes are being made and why?

Hi !

I'd like to add loadBalancerIP to service spec to allow use cases such as Internal Load Balancers on Google Kubernetes Engine with static internal IP reserved in advance.
It helps with:

  • Increasing security by not exposing the service with an external IP.
  • Allowing more advanced automation in provisioning infrastructure.

See this, this and this.


How the changes have been QAed?

Tested on GKE v1.27.8-gke.1067004 STABLE Release Channel with the Kestra chart deployed with helmfime 0.162.0 as a local chart and these values:

service:
  type: LoadBalancer
  loadBalancerIP: 10.42.0.30
  annotations:
    networking.gke.io/load-balancer-type: "Internal"

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@loicmathieu loicmathieu merged commit 57e049f into kestra-io:master Mar 12, 2024
@pdemagny pdemagny deleted the feat/loadbalancerip branch March 12, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants