Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/deprecated-warnings #1994

Merged
merged 3 commits into from
Sep 4, 2023
Merged

feat/deprecated-warnings #1994

merged 3 commits into from
Sep 4, 2023

Conversation

brian-mulier-p
Copy link
Member

closes #1713

@brian-mulier-p brian-mulier-p self-assigned this Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@loicmathieu
Copy link
Member

Maybe it's my screen but the warning color is very light in light mode and would be better with more contrast.
image

@loicmathieu
Copy link
Member

I tested it and deprecated fields are not showing up, see this example:

id: hello-deprecation
namespace: dev
tasks:
  - id: hello
    type: io.kestra.core.tasks.debugs.Echo
    format: Hello World
  - id: bash
    type: io.kestra.core.tasks.scripts.Python
    files:
      - "toto.txt"

Only task deprecations are shown whereas the files property is also deprecated.

image

loicmathieu
loicmathieu approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p merged commit 8fba5ee into develop Sep 4, 2023
4 of 5 checks passed
@brian-mulier-p brian-mulier-p deleted the feat/deprecated-warnings branch September 4, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
No open projects
All issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a warning when a deprecated feature is used in a Flow
2 participants
@brian-mulier-p @loicmathieu