Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flatten #2537

Merged
merged 13 commits into from
Nov 24, 2023
Merged

add flatten #2537

merged 13 commits into from
Nov 24, 2023

Conversation

EdwardLi-coder
Copy link
Contributor

feat(core):#2463

@Skraye
Copy link
Member

Skraye commented Nov 16, 2023

Hi @EdwardLi-coder, thank you for your contribution! Could you add a test, please?

@EdwardLi-coder
Copy link
Contributor Author

Hi @EdwardLi-coder, thank you for your contribution! Could you add a test, please?

Sure.I will add a test.

@EdwardLi-coder
Copy link
Contributor Author

Hello @Skraye, I've added a test. Could you please review it? Thank you.

Skraye
Skraye approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, QA + code

@Skraye Skraye merged commit fad528f into kestra-io:develop Nov 24, 2023
4 checks passed
@EdwardLi-coder EdwardLi-coder deleted the add_flatten_filter branch November 24, 2023 21:46
@anna-geller anna-geller mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwardLi-coder @Skraye