Adding an env vars to configure traxor on the fly #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketiko
changed the title
calaway
reviewed
Aug 21, 2018
| @@ -21,4 +17,25 @@ def self.initialize_logger(log_target = STDOUT) | |||
| end | |||
| @logger | |||
| end | |||
|
|
|||
| def self.enabled? | |||
| @enabled ||= ENV.fetch('TRAXOR_ENABLED', true).present? | |||
There was a problem hiding this comment.
I don't think this will return false as expected. For example, if an env var TRAXOR_ENABLED=false is set, then ENV.fetch('TRAXOR_ENABLED', true) will return the string 'false' (not a boolean), and then 'false'.present? returns true.
I think we want to ask for a positive on the env var. So if Traxor is disabled by default we would want
@enabled ||= !ENV['TRAXOR_ENABLED'].nil?Or if Traxor is enabled by default we would want
@enabled ||= ENV['TRAXOR_DISABLED'].nil?Let me know if I'm missing something here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.