Bugfix/pad end tflite #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in tflite pad_end logic
|
hi, thanks for the PR! i'm struggling to fix travis issue now, just fyi. |
|
Hi thanks for that, I'm not sure what the issue is, I wonder if it is related to merging from a fork rather than a branch, although we did this before... |
|
oh, no worries. |
keunwoochoi
added a commit
that referenced
this pull request
Nov 14, 2021
* Bugfix/pad end tflite (#131) * update tensorflow requirements to have optional gpu version * Update README.md * Update README.md * update CI * remove extras requirement * Add test for pad_end Fix bug in tflite pad_end logic * add missing arg * comment * better comment * revert readme to master * update travis * Revert readme * better readme * test pad end * Add tflite documentation * with * Add comment and formatting Co-authored-by: Paul Kendrick <paul.kendrick@musictribe.com> * bump version to 0.3.6 * reformat * add release note Co-authored-by: Paul Kendrick <kenders2000@gmail.com> Co-authored-by: Paul Kendrick <paul.kendrick@musictribe.com>
|
@kenders2000 merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue that was calculating the padding to be applied when using the
pad_endparameter incorrectly. issue #124 (sorry for the delay I forgot to fix this in the main Kapre fork!)Also added some documentation highlighting the restrictions to a batch size of one for the tflite compatible layers as raised in issue #130