-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chord sentences, one per line #1
Conversation
instead of using `__START__` / `__END__` delimiters
Thanks for PR. What would be it good about this change? I think using delimiters are more common. We can then see what happens when the network meet them. Also the code is written for that.
… On 6 Feb 2017, at 20:01, Loisaida Sam ***@***.***> wrote:
instead of using __START__ / __END__ delimiters
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
Chord sentences, one per line
File Changes
M chord_sentences.txt (2848)
Patch Links:
https://github.com/keunwoochoi/lstm_real_book/pull/1.patch
https://github.com/keunwoochoi/lstm_real_book/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hi Keunwoo, First off, this is amazing and quite inspiring. Thank you for your hard work. My initial thoughts were that it'd be helpful for (human) readability, but I see what you mean, that the RNNs actually parse the delimiters as inputs. I was thinking about other analyses that could be done on these sentences, perhaps by using vector representations of the chords that each sentence contains to do some sort of similarity comparison between sentences themselves. Would it be possible to get a list of the song titles represented by each "sentence" of chords? |
Here's what a CSV of songs w/ titles and associated chords might look like: |
Thanks! |
Hey @keunwoochoi, To confirm the ordering, I looked at the That worked just fine, but it seems that all of the files included in the repo are in their original keys, not transposed to C. I don't have any easy way of transposing them (I don't have Anyway, what did you do to transpose the tunes to C? Did you use In the mean time, I wrote some scripts to do a little automated regex matching to try and match the patterns of chord types against the results in My writing is getting a bit egregious for a closed pull request, so I'm going to open an issue if you don't mind, and we can continue the discussion there :) -Sam PS. Re: the vector representation, I have a few ideas. To get started, I was thinking something along the lines of creating custom embeddings based on the n-grams contained in each "sentence" of chords. I will elaborate on that a bit later once some more of the data wrangling is done. |
|
PS. I have been/will be extremely busy for about a month, so please excuse me if I'm not too responsive! |
instead of using
__START__
/__END__
delimiters