Update container name on docs #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
tuhuynh27
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: Nguyen Dang Dai Hiep <hiepndd@Nguyens-MacBook-Pro.local>
tuhuynh27
pushed a commit
that referenced
this pull request
Jun 25, 2022
* config improvement (#104) * add config improvement * fix unit test fails * fix unit test fails * fix unit test fails * fix unit test fails * fix container name on docs (#106) Co-authored-by: Nguyen Dang Dai Hiep <hiepndd@Nguyens-MacBook-Pro.local> * #18 add base classes for replication feature * fix bug making server failed to start * add base of communication flow * add partial sync overall logic * add PSYNC command and outline for master logic * update PSYNC impl and add Master Test * update ReplicationBuffer dump method, test cmd replicating * add base for REPLCONF command for master-slave communication * implementing REPLCONF, add slave context * update slave context when REPLCONF and start cmd forwarding thread when receive REPLCONF ACK * working replication with 1 master 1 slave * resolve conflict, update code to match * add 200ms sleep before checking values replicated * fix AOF test assume dump file already present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.