Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support M1 Docker image #114

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Support M1 Docker image #114

merged 1 commit into from
Apr 3, 2022

Conversation

hiepndd
Copy link
Contributor

@hiepndd hiepndd commented Mar 29, 2022 •
edited by tuhuynh27
Loading

Resolves #107

@hiepndd hiepndd changed the title add Dockerfile for m1 Support M1 Docker image Mar 29, 2022
@tuhuynh27 tuhuynh27 added the enhancement New feature or request label Apr 1, 2022
@tuhuynh27 tuhuynh27 linked an issue Apr 1, 2022 that may be closed by this pull request
Support M1 Docker image #107
Closed
@tuhuynh27
Copy link
Member

Thanks @hiepndd, we will test build on M1 mac machine and merge this pull request

tuhuynh27
tuhuynh27 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@tuhuynh27 tuhuynh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhuynh27
Copy link
Member

Keva Docker image can now work on M1 machines, thanks @hiepndd 🎉

keva-server:1.0.0-rc0-arm

FYI @axblueblader @yampml

@tuhuynh27 tuhuynh27 merged commit 6135007 into keva-dev:develop Apr 3, 2022
@tuhuynh27 tuhuynh27 mentioned this pull request Apr 3, 2022
Closed
@tuhuynh27 tuhuynh27 mentioned this pull request May 19, 2022
Merged
tuhuynh27 pushed a commit that referenced this pull request May 19, 2022
@hiepndd @tuhuynh27
add Dockerfile for M1 machines (#114)
7929a15 
Co-authored-by: Nguyen Dang Dai Hiep <hiepndd@Nguyens-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuhuynh27 tuhuynh27 tuhuynh27 approved these changes

@axblueblader axblueblader Awaiting requested review from axblueblader

@duongcongtoai duongcongtoai Awaiting requested review from duongcongtoai

@haphananhtuan haphananhtuan Awaiting requested review from haphananhtuan

@the123saurav the123saurav Awaiting requested review from the123saurav

@yampml yampml Awaiting requested review from yampml

Assignees

@hiepndd hiepndd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support M1 Docker image
2 participants
@hiepndd @tuhuynh27