Refactor unit tests #139
Merged
Refactor unit tests #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 31, 2022 22:42
taivtse
requested review from
tuhuynh27,
yampml,
haphananhtuan,
ThanhChinhBK,
axblueblader,
duongcongtoai,
TuanHungVU1202 and
the123saurav
|
Some tests are failing, can you check @taivtse P/S: Failing on my local also |
I fixed it. Thank you. |
Merged
tuhuynh27
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Refactor unit tests * Remove redundant try catch blocks in unit tests * Move subscriber to PubSubCommandTest * Move subscriber to PubSubCommandTest * Refactor unit tests * Update test cases Co-authored-by: TaiVT <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team, please help me review the new code structure for our unit tests.