Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement string command DECR, DECRBY, GETRANGE #78

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Implement string command DECR, DECRBY, GETRANGE #78

merged 1 commit into from
Dec 19, 2021

Conversation

yampml
Copy link
Member

@yampml yampml commented Dec 16, 2021 •
edited by tuhuynh27
Loading

Implement #59

@tuhuynh27 tuhuynh27 changed the title add string command decr, decrby, getrange Implement string command DECR, DECRBY, GETRANGE Dec 16, 2021
@tuhuynh27 tuhuynh27 added the enhancement New feature or request label Dec 16, 2021
@tuhuynh27 tuhuynh27 added this to the First Release milestone Dec 16, 2021
@tuhuynh27 tuhuynh27 linked an issue Dec 16, 2021 that may be closed by this pull request
String commands implementation #59
Closed
11 tasks
@tuhuynh27
Copy link
Member

Don't forget to update docs on the website, ref https://github.com/keva-dev/keva/pull/55/files#diff-f0a6bf8edd363560735f8cabf8ad1b8f62d6d171c968ad63d60497d2ef1fbb56

@yampml yampml force-pushed the feature/string-cmds-impl branch 6 times, most recently from 1060e97 to 7fcef22 Compare December 19, 2021 13:46
tuhuynh27
tuhuynh27 approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@tuhuynh27 tuhuynh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuhuynh27 tuhuynh27 merged commit 8a41c8b into develop Dec 19, 2021
@tuhuynh27 tuhuynh27 deleted the feature/string-cmds-impl branch December 19, 2021 14:26
@tuhuynh27 tuhuynh27 mentioned this pull request Dec 19, 2021
Merged
tuhuynh27 pushed a commit that referenced this pull request Dec 19, 2021
@yampml @tuhuynh27
implements string command decr, decrby, getrange, incrbyfloat, mset (#78
ce92f0a 
)
@tuhuynh27 tuhuynh27 mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuhuynh27 tuhuynh27 tuhuynh27 approved these changes

@axblueblader axblueblader Awaiting requested review from axblueblader

@duongcongtoai duongcongtoai Awaiting requested review from duongcongtoai

@haphananhtuan haphananhtuan Awaiting requested review from haphananhtuan

@the123saurav the123saurav Awaiting requested review from the123saurav

Assignees

@yampml yampml

Labels
enhancement New feature or request
Projects
None yet
Milestone
First Release
Development

Successfully merging this pull request may close these issues.

String commands implementation
2 participants
@yampml @tuhuynh27