move expiration logic inside DB impl #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add the same logic for OnHeapImpl @axblueblader |
replace chronicleMap.put with this.put only for command that 'replace' the value present
axblueblader
requested review from
yampml,
the123saurav,
duongcongtoai and
haphananhtuan
haphananhtuan
approved these changes
Dec 20, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
changes:
[x] move expiration logic to DB impl, remove ExpirationManager completely
[x] swap appropriate chroniclemap 'get' and 'put' calls to use internal calls instead
[x] apply same logic for onheap
Need help review if any of newly added commands suppose to use 'this' function (has expiration logic) instead of calling pure 'map' functions and vice versa
basically if a command is suppose to completely replace a value at a key with a different value (SET, MSET, DEL) then it should have expiration logic, commands that attempts to alter value (INCR, LPUSH, HSET) doesn't change expiration timestamp
https://redis.io/commands/expire