Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables from maven properties are double-quoted #126

Closed
kevin-lee opened this issue Sep 4, 2020 · 0 comments · Fixed by #127
Closed

Variables from maven properties are double-quoted #126

kevin-lee opened this issue Sep 4, 2020 · 0 comments · Fixed by #127
Assignees
Labels
Milestone

Comments

@kevin-lee
Copy link
Owner

kevin-lee commented Sep 4, 2020

Bug

Variables from maven properties are quoted.

Summary

Project Details

Version: 0.4.0
Scala Version: n/a
Java Version: n/a

Description

The variable from maven property is double-quoted when it's used.

...
  <properties>
    <junit.version>4.11</junit.version>
  </properties>

...
  <dependencies>
    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>${junit.version}</version>
      <scope>test</scope>
    </dependency>
</dependencies>

results in

"junit" % "junit" % "junitVersion" % Test

but it should be

"junit" % "junit" % junitVersion % Test

So junitVersion should not be double-quoted.

@kevin-lee kevin-lee added the bug label Sep 4, 2020
@kevin-lee kevin-lee added this to the milestone5 milestone Sep 4, 2020
@kevin-lee kevin-lee self-assigned this Sep 4, 2020
@kevin-lee kevin-lee changed the title Variables from maven properties are quoted Variables from maven properties are double-quoted Sep 4, 2020
kevin-lee added a commit that referenced this issue Sep 5, 2020
Fix #126 - Variables from maven properties are double-quoted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant