Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy: server crashes when invalid SSL requests happen #25

Closed
kevin1024 opened this issue Feb 12, 2015 · 4 comments
Closed

pypy: server crashes when invalid SSL requests happen #25

kevin1024 opened this issue Feb 12, 2015 · 4 comments
Labels

Comments

@kevin1024
Copy link
Owner

When an SSL exception happens in the server, it shouldn't freeze up the server and prevent it from finishing the request (or doing subsequent requests)

@kevin1024
Copy link
Owner Author

@msabramo
Copy link
Collaborator

Nice sleuthing, @kevin1024 !

@kevin1024
Copy link
Owner Author

OK, this was a little different than I thought, so I hope it still fixes all the issues.

What was happening is that on pypy, the version of the stdlib doesn't seem to set a timeout for the SSL socket. So when the validation was failing, it was just hanging. I manually set a timeout on the socket, and it seems to have fixed the issue.

Please reopen if this didn't solve it, but I can't reproduce the error anymore so it seems to have fixed something!

@kevin1024
Copy link
Owner Author

fixed in f38a312 (for future reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants