Replace assert with raise AssertionError (fixes support for PYTHONOPTIMIZE=1)
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert seems to behave badly in some cases and should not be used for handling runtime errors. see for example: https://medium.com/@jadhavmanoj/python-what-is-raise-and-assert-statement-c3908697bc62 https://github.com/emre/notes/blob/master/python/when-to-use-assert.md
hartwork
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Hi @neliseiska,
I confirm that (1) without this pull request export PYTHONOPTIMIZE=1 makes the current code fail and (2) with this pull requests those failing tests turn green. Hence I will merge this pull request. Thanks for your contribution to VCR.py! 🙏
Best, Sebastian
hartwork
changed the title
assert with raise AssertionErrorassert with raise AssertionError (fixes support for PYTHONOPTIMIZE=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert seems to behave badly in some cases and should not be used for
handling runtime errors.
See for example:
https://medium.com/@jadhavmanoj/python-what-is-raise-and-assert-statement-c3908697bc62
https://github.com/emre/notes/blob/master/python/when-to-use-assert.md