Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix list formatting in changelog for v5.1.0 #771

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

Mr0grog
Copy link
Contributor

@Mr0grog Mr0grog commented Sep 29, 2023

This is really just a typo fix. I noticed that the changelog for v5.1.0 is getting rendered as a paragraph instead of a list because it wasn't indented enough:

Screenshot of changelog rendered as a paragraph

This change just fixes the indentation so it renders as a list:

Screenshot of changelog after this change

While I was at it I removed dangling spaces at the end of lines in the changelog (actually my editor just did this automatically, since it’s in the project’s .editorconfig file) and added a blank line between the latest 4.x release and 5.0.0, since all the other major versions have extra blank lines between them.

The list of changes was not indented enough, and so didn't actually get formatted as a list when rendering HTML, which left it pretty unreadable. This also adds a blank line between the last 4.x version and 5.0.0 to match the extra blank lines between other major versions.
This matches the project's `.editorconfig` rules.
@Mr0grog Mr0grog changed the title Fix list formatting in changelog for v5.1.0 docs: Fix list formatting in changelog for v5.1.0 Sep 29, 2023
Copy link
Collaborator

@jairhenrique jairhenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jairhenrique jairhenrique merged commit c062c9f into kevin1024:master Dec 8, 2023
1 of 9 checks passed
@Mr0grog Mr0grog deleted the changelog-5-1-0-formatting branch December 8, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants