Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Improve documentation for white LC joint fits #530

Closed
1 task done
kevin218 opened this issue May 3, 2023 · 0 comments · Fixed by #654
Closed
1 task done

[Enhancement]: Improve documentation for white LC joint fits #530

kevin218 opened this issue May 3, 2023 · 0 comments · Fixed by #654
Assignees
@erinmmay
Labels
documentation Improvements or additions to documentation enhancement New feature or request LC Fit

Comments

@kevin218
Copy link
Owner

kevin218 commented May 3, 2023

Instrument

Light curve fitting (Stages 4-6)

What happened?

The ECFs are missing important parameters for joint white LC fitting, as is the documentation.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@github-actions github-actions bot added the LC Fit label May 3, 2023
@taylorbell57 taylorbell57 added documentation Improvements or additions to documentation enhancement New feature or request labels May 3, 2023
@kevin218 kevin218 assigned erinmmay and unassigned taylorbell57 Apr 1, 2024
@erinmmay erinmmay mentioned this issue May 26, 2024
Merged
@taylorbell57 taylorbell57 linked a pull request Jun 20, 2024 that will close this issue
Enables custom bad pixel masks (S1), user supplied wavelength files (S4), adds joint white light curve fitting parameters to docs (S5) #654
Merged
@taylorbell57 taylorbell57 changed the title Improve documentation for white LC joint fits [Enhancement]: Improve documentation for white LC joint fits Jun 20, 2024
@kevin218 kevin218 moved this to To do in Road to v1.1 Jul 26, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Road to v1.1 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erinmmay erinmmay

Labels
documentation Improvements or additions to documentation enhancement New feature or request LC Fit
Projects
Road to v1.1
Status: Done
Stage 5: Light Curve Fitting
Status: Done
Milestone
No milestone
5 participants
@kevin218 @taylorbell57 @erinmmay @meganmansfield @evamariaa