-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables custom bad pixel masks (S1), user supplied wavelength files (S4), adds joint white light curve fitting parameters to docs (S5) #654
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 58.90% 58.91%
=======================================
Files 111 111
Lines 13430 13430
=======================================
+ Hits 7911 7912 +1
+ Misses 5519 5518 -1 ☔ View full report in Codecov by Sentry. |
@kevin218, do you want to take a look at this PR too since I made a bunch of edits (and therefore am at least somewhat conflicted), or should I just merge this in now? |
@taylorbell57 yeah, I should probably take a look at your edits before merging. I can do that tomorrow. |
Addressed #638 and also enables users to supply a wavelength file in S4 for pre-computed bins. Also adds joint white light curve fitting to docs and demo ecf to address #530