Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables custom bad pixel masks (S1), user supplied wavelength files (S4), adds joint white light curve fitting parameters to docs (S5) #654

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

erinmmay
Copy link
Collaborator

@erinmmay erinmmay commented May 26, 2024

Addressed #638 and also enables users to supply a wavelength file in S4 for pre-computed bins. Also adds joint white light curve fitting to docs and demo ecf to address #530

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.91%. Comparing base (c862d8d) to head (697b066).
Report is 13 commits behind head on main.

Files Patch % Lines
src/eureka/S1_detector_processing/s1_meta.py 0.00% 2 Missing ⚠️
src/eureka/S1_detector_processing/s1_process.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   58.90%   58.91%           
=======================================
  Files         111      111           
  Lines       13430    13430           
=======================================
+ Hits         7911     7912    +1     
+ Misses       5519     5518    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erinmmay erinmmay changed the title Enables custom bad pixel masks (S1) and user supplied wavelength files (S4) Enables custom bad pixel masks (S1), user supplied wavelength files (S4), adds joint white light curve fitting parameters to docs (S5) May 26, 2024
docs/source/ecf.rst Outdated Show resolved Hide resolved
demos/JWST/S1_nirx_template.ecf Show resolved Hide resolved
docs/source/ecf.rst Outdated Show resolved Hide resolved
src/eureka/S4_generate_lightcurves/s4_genLC.py Outdated Show resolved Hide resolved
@taylorbell57
Copy link
Collaborator

@kevin218, do you want to take a look at this PR too since I made a bunch of edits (and therefore am at least somewhat conflicted), or should I just merge this in now?

@taylorbell57 taylorbell57 added enhancement New feature or request documentation Improvements or additions to documentation labels Aug 22, 2024
@kevin218
Copy link
Owner

@taylorbell57 yeah, I should probably take a look at your edits before merging. I can do that tomorrow.

@taylorbell57 taylorbell57 merged commit 7c8f5c2 into kevin218:main Aug 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
3 participants