-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Setting meta.centroids fails when nreads is not constant in each WFC3 exposure. #649
Comments
Still not sure why two of the scans in this dataset I'm working on are missing a read, but maybe we should check for consistent numbers of reads and then come up with some more informative failure mode that informs the user about the problem. Attempting to continue with the analysis gives useless results due to the inability of Eureka! to correct for "spectral drift" when a significant chunk of the scan is just missing. |
As it happens, this is sometimes done for scheduling reasons (like in this case), so we're not actually guaranteed to have spatial scans of the same size. Those scans are still good data, so there should be some way to recover them, I guess. Can we anchor the drift calculation to a particular common start point? e.g. measure the drift relative just to the green line (subpixel drift) as opposed to the red rectangle (tens of pixels) |
FAQ check
Instrument
Other (any stage)
What happened?
Some WFC3 datasets don't have consistent numbers of reads in each exposure. When this is the case, setting
meta.centroids = np.array(meta.centroids)
in the WFCconclusion_step()
will fail, due to very so slightly ragged array with an errorValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (85,) + inhomogeneous part.
I guess that step should have a
dtype=object
parameter to preserve all the read-level information for future steps rather than trying to trim or pad the number of reads.Error traceback output
What operating system are you using?
Ubuntu 22.04.03 on WSLg on Win10
What version of Python are you running?
3.10.14
What Python packages do you have installed?
Code of Conduct
The text was updated successfully, but these errors were encountered: