Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing css class="form-control" on Date Field input #351

Closed
ankurk91 opened this issue Jan 7, 2017 · 2 comments
Closed

Missing css class="form-control" on Date Field input #351

ankurk91 opened this issue Jan 7, 2017 · 2 comments

Comments

@ankurk91
Copy link

ankurk91 commented Jan 7, 2017

Hi,
The form builder have a bootstrap form-control css class on all input fields except Date Field

This is the html generated for Date input -

<input type="date" class="calendar" name="date-1483767794498-preview" id="date-1483767794498-preview">

See screenshot, taken from this page

screenshot from 2017-01-07 11-13-57
kevinchappell added a commit that referenced this issue Feb 14, 2017
@kevinchappell
Bugfix: date form-control default class #351
dafbfa1
kevinchappell added a commit that referenced this issue Feb 16, 2017
@kevinchappell
Bugfix: date form-control default class #351
e184c46
@ankurk91
Copy link
Author

@kevinchappell
Hi, seems like the referenced commits above was not included in most recent release (v1.24.5).
Above patch works well btw.
Right now i am doing a lot of hacks to add that css class. Please merge that commit.

Thanks.

kevinchappell added a commit that referenced this issue Feb 22, 2017
@kevinchappell
Bugfix: XMLParser children in ie #369, date form-control class #351
b67cfe1
kevinchappell added a commit that referenced this issue Feb 22, 2017
@kevinchappell
Bugfix: XMLParser children in ie #369, date form-control class #351 (#…
aa4216b 
…373)
kevinchappell added a commit that referenced this issue Feb 22, 2017
@kevinchappell
Bugfix: XMLParser children in ie #369, date form-control class #351 (#…
37f60cc 
…373)
@ankurk91
Copy link
Author

Many thanks for releasing 1.24.6 with the fix.

kevinchappell added a commit that referenced this issue Apr 14, 2017
@kevinchappell
Bugfix: date form-control default class #351
ee92667
kevinchappell added a commit that referenced this issue Apr 18, 2017
@kevinchappell
✨ Custom Controls, Automatic i18n, WYSIWYG Editor, HTML Labels ✨ (#414)
edad3b7 
* Add browserify, code cleanup

* v1.25.0 WIP

* 1.25.0 WIP

* Bugfix: fast clicking with editOnAdd

* Remove allowSelect from opts.messages

* Only editOnAdd for new fields

* Update gulpfile, getData action, remove bootstrap color styles

* Customizable Form action buttons, clearer selected button styles

* Fix delete toggle element

* i18n WIP, new subtypes WIP

* fieldRender refactor for inline radios and checkboxes and templates

* fieldRender refactor continued

* minor bugfix for getTemplate

* Add Quill support for rich text editing

* Fix tinymce and getScripts caching

* refactor for lower filesize

* Bugfix: disabled tooltip forn appended and prepended fields

* Add mini dom library, working autocomplete

* Fix preview value binding

* update variable

quill WIP

* Upgrade dependencies

* start disabled subtypes, extendable actionButtons WIP, text-overflow for controls

* Minors updates, jsdoc-ing

* stickyControls and Autocomplete field updates

* Bugfix: inputSet drag #368, btnStyle

* Add polyfill for ie11 #365

* Fix ie11 forEach

* Bugfix: Custom class and name attrs #355

* Bugfix: date form-control default class #351

* demo build

* Update icon font label, fix bug where custom classname and name are not used #355

* Fix Custom names, Checkbox field show 2 labels in editor #345

* Update icon font

* Update fonts, stage labels

* HTML labels WIP

* Bugfix: select field multiple options

* Doc updates WIP

* update bower deps

* Module abstraction WIP

* Upgrade packages fix style lint

* Start editorUI render function, Refactor WIP

* fix demo.js

* refactor WIP

* Start new i18n support

* multiple instance refactor WIP

* refactor WIP

* helpers refactor WIP, return promise option for formBuilder

* fix template map issue

* Begin merging checkbox and checkbox-group

* Allow underscore in attribut name 😢, Resolves #300

* Enable custom fields and templates

* fix textarea not saving value

* Add lang files for demo

* fix placeholder strings

* Fix paragraph template, update on toggle edit

* v2.0-beta

* Replace kc-toggle plugin with css only toggle solution (#412)

* Fix control drag issue

* Temporarily remove scrollIntoView(too jarring), autocomplete styling should be available for form-render.css also

* Fix required asterisk, make formData a getter

* Change default lang location

* required asterisk style update

* correct version number

* Enable html labels

* XML options rendering resolves #380

* Button not draggable resolves #378

* XML save updates

* Remove unused strings

* Fix preview layout issue, html labels
kevinchappell added a commit that referenced this issue Apr 18, 2017
@kevinchappell
✨ Custom Controls, Automatic i18n, WYSIWYG Editor, HTML Labels ✨ (#414)
7f184c1 
* Add browserify, code cleanup

* v1.25.0 WIP

* 1.25.0 WIP

* Bugfix: fast clicking with editOnAdd

* Remove allowSelect from opts.messages

* Only editOnAdd for new fields

* Update gulpfile, getData action, remove bootstrap color styles

* Customizable Form action buttons, clearer selected button styles

* Fix delete toggle element

* i18n WIP, new subtypes WIP

* fieldRender refactor for inline radios and checkboxes and templates

* fieldRender refactor continued

* minor bugfix for getTemplate

* Add Quill support for rich text editing

* Fix tinymce and getScripts caching

* refactor for lower filesize

* Bugfix: disabled tooltip forn appended and prepended fields

* Add mini dom library, working autocomplete

* Fix preview value binding

* update variable

quill WIP

* Upgrade dependencies

* start disabled subtypes, extendable actionButtons WIP, text-overflow for controls

* Minors updates, jsdoc-ing

* stickyControls and Autocomplete field updates

* Bugfix: inputSet drag #368, btnStyle

* Add polyfill for ie11 #365

* Fix ie11 forEach

* Bugfix: Custom class and name attrs #355

* Bugfix: date form-control default class #351

* demo build

* Update icon font label, fix bug where custom classname and name are not used #355

* Fix Custom names, Checkbox field show 2 labels in editor #345

* Update icon font

* Update fonts, stage labels

* HTML labels WIP

* Bugfix: select field multiple options

* Doc updates WIP

* update bower deps

* Module abstraction WIP

* Upgrade packages fix style lint

* Start editorUI render function, Refactor WIP

* fix demo.js

* refactor WIP

* Start new i18n support

* multiple instance refactor WIP

* refactor WIP

* helpers refactor WIP, return promise option for formBuilder

* fix template map issue

* Begin merging checkbox and checkbox-group

* Allow underscore in attribut name 😢, Resolves #300

* Enable custom fields and templates

* fix textarea not saving value

* Add lang files for demo

* fix placeholder strings

* Fix paragraph template, update on toggle edit

* v2.0-beta

* Replace kc-toggle plugin with css only toggle solution (#412)

* Fix control drag issue

* Temporarily remove scrollIntoView(too jarring), autocomplete styling should be available for form-render.css also

* Fix required asterisk, make formData a getter

* Change default lang location

* required asterisk style update

* correct version number

* Enable html labels

* XML options rendering resolves #380

* Button not draggable resolves #378

* XML save updates

* Remove unused strings

* Fix preview layout issue, html labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankurk91