Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start tracking until it goes zero #182

Closed

Conversation

kevincobain2000
Copy link
Owner

I wanted to use this linter TBH. In my company we have started using it too.

Reason for this pull request is because

I looked at the errors produced by the linter. It is a half day job to fix the errors. I don't think we are going to be fixing the lint errors anytime soon. However, we can still add the linter and at least start tracking the counts to go down.

╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/golangci-lint-fix●›
╰─$ golangci-lint run ./... | grep  -c "\^"                                                                                                                                                                                                           130 ↵
25
╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/golangci-lint-fix●›
╰─$ echo $?
0

@kevincobain2000 kevincobain2000 changed the base branch from master to feature/golangci-lint February 10, 2024 12:14
Copy link

CoverItUp Report

TYPE MASTER FEATURE/GOLANGCI-LINT-FIX
coverage 60.5% 59.2%-
build-time 3sec 25sec+
go-binary-size 6.1kKB 6.1kKB
go-mod-dependencies 29 28-
go-sec-issues 6 6
unit-test-run-time 18sec 19sec+
go-lint-errors 0 25+

chartchartchartchartchartchartchart

Add Badges and Charts to Readme

@@ -55,6 +56,14 @@ jobs:
echo SCORE=$(($SECONDS-BUILD_START)) >> "$GITHUB_ENV"
shell: bash

- name: Lint Errors
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes and I removed the separate workflow file.
Once we have zero counts on the lint, will update this CI to exit 1 upon any errors.

@kevincobain2000 kevincobain2000 deleted the feature/golangci-lint-fix branch February 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant