Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'x-hack' from grub and bsp packages #32

Open
wants to merge 1 commit into
base: central
Choose a base branch
from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Sep 18, 2023

Description

This PR removes the usage of 'x-hack' in the grub and bsp packages of the armbian-build repository. The 'x-hack' is a common practice in shell scripting for string comparison to avoid syntax errors when one of the variables is empty or unset. However, it is not necessary when using the double bracket conditional construct [[ ]], which can handle empty variables. The 'x-hack' comparisons have been replaced with direct comparisons using double brackets [[ ]].

Summary of Changes

  • In packages/bsp/nanopim4/nanopim4-pwm-fan.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].
  • In packages/blobs/grub/09_linux_with_dtb.sh, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].

Please review the changes and merge this PR if it meets the requirements. Thank you!

Fixes #19.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Remove x-hack from grub and bsp packages
0 participants