Remove 'x-hack' from grub and bsp packages #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the usage of 'x-hack' in the grub and bsp packages of the armbian-build repository. The 'x-hack' is a common practice in shell scripting for string comparison to avoid syntax errors when one of the variables is empty or unset. However, it is not necessary when using the double bracket conditional construct [[ ]], which can handle empty variables. The 'x-hack' comparisons have been replaced with direct comparisons using double brackets [[ ]].
Summary of Changes
packages/bsp/nanopim4/nanopim4-pwm-fan.sh
, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].packages/blobs/grub/09_linux_with_dtb.sh
, replaced all instances of 'x-hack' comparisons with direct comparisons using double brackets [[ ]].Please review the changes and merge this PR if it meets the requirements. Thank you!
Fixes #19.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: