Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] comment-changes: Stop at Certain Commit SHA; fixes #336 #353

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

kevinmatthes
Copy link
Owner

This PR fixes #336.

@kevinmatthes kevinmatthes added the enhancement New feature or request label Jun 18, 2023
@kevinmatthes kevinmatthes added this to the v3.0.0 milestone Jun 18, 2023
@kevinmatthes kevinmatthes self-assigned this Jun 18, 2023
@github-actions
Copy link
Contributor

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  -----------------------------
src/graphing/agd.rs                      156       0  100.00%
src/graphing/graph.rs                    146       0  100.00%
src/application.rs                        55      55  0.00%    115-209
src/cffreference.rs                       68       0  100.00%
src/macros.rs                              4       0  100.00%
src/running.rs                             4       0  100.00%
src/version.rs                            60       0  100.00%
src/pattern/buffer.rs                     21       0  100.00%
src/pattern/io_processor.rs               19      19  0.00%    72-160
src/pattern/reader.rs                     32      21  34.38%   57-58, 75-79, 90-109, 123-140
src/pattern/writer.rs                     75      30  60.00%   133-152, 187-197, 229-257
src/changelog/action.rs                   11       0  100.00%
src/changelog/comment_changes.rs         166     166  0.00%    110-410
src/changelog/fragment.rs                 21       0  100.00%
src/changelog/ronlog.rs                   74      74  0.00%    35-229
src/changelog/section.rs                  48       0  100.00%
src/traits/append_as_line.rs               9       0  100.00%
src/traits/colour_message.rs               8       0  100.00%
src/traits/convert_buffer.rs              21       0  100.00%
src/traits/prefer.rs                       3       0  100.00%
src/traits/rusty_object_notation.rs        8       0  100.00%
src/traits/to_stderr.rs                    4       0  100.00%
TOTAL                                   1013     365  63.97%

Copy link
Owner Author

@kevinmatthes kevinmatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some explanations on my changes; @AmmarAbouZor, is this implementation okay for your use case (#336)?

src/changelog/comment_changes.rs Show resolved Hide resolved
src/changelog/comment_changes.rs Show resolved Hide resolved
@kevinmatthes kevinmatthes enabled auto-merge (squash) June 19, 2023 13:38
@kevinmatthes kevinmatthes merged commit db56cc8 into main Jun 19, 2023
@kevinmatthes kevinmatthes deleted the feature/336 branch June 19, 2023 13:39
@AmmarAbouZor
Copy link

@kevinmatthes This should work perfectly in my use case. Thanks for implementing it 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Run comment-changes with a scheduled interval
2 participants