Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing linear paths, new test #16

Merged
merged 11 commits into from
Jan 3, 2017
Merged

Collapsing linear paths, new test #16

merged 11 commits into from
Jan 3, 2017

Conversation

standage
Copy link
Collaborator

This PR introduces:

  • A new test based on a 5bp deletion in the case relative to two controls. All existing tests only test for SNPs.
  • Collapsing of linear paths associated with "interesting" k-mers. Often the linear path associated with one interesting k-mer is a subsequence of the linear path associated with a different interesting k-mer. These we can collapse trivially.

@standage
Copy link
Collaborator Author

kevlar find \
    --controls tests/data/trio1/ctrl?.counts \
    --case tests/data/trio1/case4.counts \
    --out novel.txt \
    --paths-out novel.paths \
    --ctrl_max 0 \
    --case_min 8 \
    tests/data/trio1/case4.fq

Try with/without the --collapse flag.

@standage
Copy link
Collaborator Author

Updated the scripts for simulating SNPs and indels to report small snippets of the mutated sequences, and updated the tests to test directly for these mutated snippets instead of for entire linear paths (which may change depending on sequencing errors, FP rate, etc.).

@standage
Copy link
Collaborator Author

standage commented Jan 3, 2017

Last week in this PR I started exploring different parameters a bit (k size, sequencing error rate, etc.) and integrating this into the automated test suite. However, this has crossed the line from testing to evaluation and analysis. These parameters are important to explore, but should not hold up work on implementing and evaluating the core algorithm.

I'm going to go ahead and merge this PR to that the deletion test and the linear path collapsing can be in master. I've opened up #21 as a placeholder for continued discussion.

@standage standage merged commit f5a9401 into master Jan 3, 2017
@standage standage deleted the refactor/seq branch January 3, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant