Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Updated NPM packages #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArturAmpilogov
Copy link

  • Removed @google-cloud/firestore dependency. Starting from firebase-admin v10 it is possible to import FieldValue, FieldPath directly from the package.
  • Rewrote firebase-admin import to modular style (const { initializeApp } = require('firebase-admin/app')).
  • Moved firebase-admin to peerDependencies.
  • For local usage upgraded firebase-admin to v11.
  • Upgraded @firebase/rules-unit-testing and the relative code for testing.
  • Upgraded firebase-tools dev dependency.

Copy link

@KoenLippe KoenLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just today I ran into some problems regarding the mismatch of my functions project which uses firebase-admin and fireway which uses @google-cloud/firestore. This resulted in errors regarding the mismatch of types between the packages.

I figured that if fireway was based on firebase-admin it would solve my problems. Came here to see if someone else already did something like this, thanks!

+1 for this PR


What is the main difference between these two packages?

@ArturAmpilogov
Copy link
Author

It looks that @kevlened is busy and does not have much time to support this awesome project.

So, I've made a lot of changes and improvements and published the new version at @dev-aces/fireway.
It needs some updates, like moving tests to jest, providing -add option to add a migration file, set up Github workflow. But those are less critical.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants