Add support for worktrees in fromExisting
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for worktree paths in `GitDir.fromExisting`. Worktrees are identified based on whether the `$GIT_DIR` and `$GIT_COMMON_DIR` are different (although not sure there are any edge cases worth understanding here). The logic is refactored a bit to make clear that the only times when `GitDir.fromExisting` throws are in the cases where: `gitDirRoot` is not a git directory or worktree; or `gitDirRoot` is a subdirectory of a git directory or worktree and `allowSubdirectory` is `false`.
kevmoo
requested changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for worktree paths in
GitDir.fromExisting. Worktrees are identified based on whether the$GIT_DIRand$GIT_COMMON_DIRare different (although not sure there are any edge cases worth considering here).The logic is refactored a bit to make clear that the only times when
GitDir.fromExistingthrows are in the cases where:gitDirRootis not a git directory or worktreegitDirRootis a subdirectory of a git directory or worktree andallowSubdirectoryisfalse.