Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

750px vs 720px #73

Closed
metbril opened this issue Mar 3, 2022 · 2 comments
Closed

750px vs 720px #73

metbril opened this issue Mar 3, 2022 · 2 comments

Comments

@metbril
Copy link
Contributor

metbril commented Mar 3, 2022

Why is this at 750px and all others at 720px?

(I'm a CSS noob)

simple.css/simple.css

Line 246 in 357a05e

@media only screen and (max-width: 750px) {

@Jieiku
Copy link

Jieiku commented Mar 13, 2022

if it was overlooked by accident when updating values, then I would argue that using sass and variables could have prevented this.

kevquirk added a commit that referenced this issue Apr 7, 2022
@kevquirk
Fixed 750px media query (#73)
aad3ee5
@kevquirk
Copy link
Owner

kevquirk commented Apr 7, 2022

Thanks for this and apologies for the delay in reply. It was an oversight, which I've just fixed.

@kevquirk kevquirk closed this as completed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jieiku @metbril @kevquirk