New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer set deprecated xmlVersion and xmlEncoding fields #57

Merged

kewisch merged 1 commit into kewisch:main from nicolaslohrer:fix-xml-encoding-2

Nov 25, 2023

nicolaslohrer commented Nov 13, 2023

See #56.

nicolaslohrer mentioned this pull request

Cannot set property xmlEncoding of #<Document> which has only a getter #56

Closed


          fix: no longer set deprecated xmlVersion and xmlEncoding fields

9194cfc

kewisch force-pushed the fix-xml-encoding-2 branch from d047a02 to 9194cfc Compare

November 25, 2023 22:52

Owner

kewisch commented Nov 25, 2023

Thanks, appreciate it. Agree these can go.

kewisch merged commit 44a8d7d into kewisch:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet