Fix the HepPDT related cmake warning and make sure that all tests build #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
commented
Sep 16, 2024
| @@ -18,6 +18,8 @@ include(cmake/Key4hepConfig.cmake) | |||
| # - Use GNU-style hierarchy for installing build products | |||
| include(GNUInstallDirs) | |||
|
|
|||
| list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") | |||
There was a problem hiding this comment.
@andresailer anything better that we can do here?
tmadlener
force-pushed
the
fix-heppdt-warning
branch
from
51d5889
to
0611519
Compare
tmadlener
force-pushed
the
fix-heppdt-warning
branch
from
0611519
to
68c53f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
HepPDTENDRELEASENOTES