Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmX information modal #42

Merged
merged 33 commits into from
Jun 28, 2024
Merged

dmX information modal #42

merged 33 commits into from
Jun 28, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

  • As @kjvbrt requested on Help+Contact+Doc link modal #40, a new modal with information about dmx has been developed.
  • This information modal is available on any screen (startup screen, on an event, etc).

ENDRELEASENOTES
We still need to know what else to add to the modal. I've added some very basic information. We can add more.
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-28 14:04 UTC

@brauliorivas brauliorivas linked an issue Jun 22, 2024 that may be closed by this pull request
Help+Contact+Doc link modal #40
Closed
@tmadlener
Copy link
Contributor

Very nice, I think what is currently missing

  • A link to the github issues for reporting issues
  • You should also put your name there since you are doing all the work. We can also put GSoC there for good measure
  • I think Jurajs and my email address (ideally in a way to make it on entirely trivial to crawl them automatically) should get next to our names, otherwise contacting us is not too easy

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jun 26, 2024

Looks good to me, I'm OK with merging this (don't forget rename dmX -> eede)

@kjvbrt kjvbrt merged commit 0aa445b into key4hep:main Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help+Contact+Doc link modal
3 participants
@brauliorivas @tmadlener @kjvbrt