Cache files created in $HOME -- XDG Base Directory Implementation Bug

[alichtman]

First, thanks for supporting the XDG Base Dir spec!

I found this file in my $HOME directory:

$ cat .cachekeybase.app.serverConfig
{"alichtman":{"chatIndexProfilingEnabled":false,"dbCleanEnabled":false,"printRPCStaus":false},"lastLoggedInUser":"alichtman"}

It seems like the path is supposed to be .cache/keybase.app.serverConfig, but is missing a slash. I think this path is generated here:

client/shared/constants/platform.desktop.tsx

Lines 60 to 68 in 324f112

	const logDir = (useXDG && env.XDG_CACHE_HOME) || Path.join(homeEnv, '.cache', appName)
	return {
	cacheRoot: logDir,
	dataRoot: (useXDG && env.XDG_DATA_HOME) || Path.join(homeEnv, '.local/share', appName),
	guiConfigFilename: Path.join(homeConfigDir, appName, 'gui_config.json'),
	jsonDebugFileName: `${logDir}keybase.app.debug`,
	logDir,
	serverConfigFileName: `${logDir}keybase.app.serverConfig`,

It seems like $XDG_CACHE_HOME is assumed to have a trailing slash, but this is non-default.

The XDG Base Dir spec says:

$XDG_CACHE_HOME defines the base directory relative to which user-specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used.

Some logic could be added to check for a trailing slash at the end of $XDG_CACHE_HOME to avoid creating this file in the wrong directory.

[maquinas07]

Just noticed this as well, I created a PR with a fix.