Util tweaks #63
Util tweaks #63
Conversation
gabriel
commented
May 9, 2016
•
gabriel
commented
- Move rand util stuff into rand.go
- RandString changed to RandomID and uses 256 bits
- Move string util into strings.go
- Move rand util into rand.go - RandString changed to RandomID and uses 256 bits - Move string util into strings.go
|
@keybase/updater-hackers |
| if !strings.HasPrefix(s, "prefix.") { | ||
| t.Errorf("Invalid prefix: %s", s) | ||
| } | ||
| if len(s)-len("prefix.") != 52 { |
There was a problem hiding this comment.
does this actually work if the random number encodes with padding (which then gets removed)?
There was a problem hiding this comment.
Good catch, yeah the padding remove should only happen from the returned base32 string. Fixed with test.
| if !strings.HasPrefix(s, "prefix=") { | ||
| t.Errorf("Invalid prefix: %s", s) | ||
| } | ||
| if len(s)-len("prefix.") != 52 { |
There was a problem hiding this comment.
even with the above fix won't this fail sometimes? sometimes the base32 encoding will have padding / won't (or is that not true). It seems like if it does sometimes and doesn't sometimes, then the length of the random string (ignoring prefix) will be variable length (cause we strip it sometimes) so it won't always be 52 long. like sometimes it'll be 51 and still be working fine
There was a problem hiding this comment.
ah.. the random id is always 256 bits (as suggested by https://gist.github.com/tqbf/be58d2d39690c3b366ad)... this means the padding will always be the same
