Color names (with and without underscores) #1309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A list of constexpr colors have been defined to match the names used in CSS, with a few minor tweaks where the colors look dramatically different on the Model 01. Signed-off-by: JD Lien <jd@jdlien.com>
This reverts commit aec5590. Signed-off-by: JD Lien <jd@jdlien.com>
Signed-off-by: JD Lien <jd@jdlien.com>
keygroups gives a variety of groups that can be used by plugins to determine if a given key object is within a particular group, such as alphabetical keys, number keys, modifiers, mouse movement keys, etc. This was developed originally for FunctionalColors. Signed-off-by: JD Lien <jd@jdlien.com>
Signed-off-by: JD Lien <jd@jdlien.com>
Added colors.h to have the CSS color names in the kaleidoscope::colors namespace. LEDEffect-SolidColor now has support for using cRGB objects via a new alternate constructor, and works with the color names. Keygroups.h has been added to offer functions that allow determining if a given key is in a certain group. Signed-off-by: JD Lien <jd@jdlien.com>
At @obra’s request, I have removed keygroups.h so that this PR can focus on colors. Signed-off-by: JD Lien <jd@jdlien.com>
Signed-off-by: JD Lien <jd@jdlien.com>
Signed-off-by: JD Lien <jd@jdlien.com>
Signed-off-by: JD Lien <jd@jdlien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update (three years later) of #668
that adds the requested underscored names to the PR.
The non-underscored variants are included in a single section so they could easily be removed to reduce redundancy, but either way will not result in additional memory use.