This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 281
KEYCLOAK-13743 Do not panic on missing Keycloak cluster #163
Merged
slaskawi
merged 1 commit into
keycloak:master
from
slaskawi:KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster
Apr 23, 2020
Merged
KEYCLOAK-13743 Do not panic on missing Keycloak cluster #163
slaskawi
merged 1 commit into
keycloak:master
from
slaskawi:KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster
Apr 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JiyeYu @pb82 @davidffrench May I ask you for review? |
davidffrench
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed now @slaskawi
slaskawi
force-pushed
the
KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster
branch
from
April 9, 2020 09:00
0623602
to
11efad6
Compare
@davidffrench Updated and re-pushed. |
golangcibot
reviewed
Apr 9, 2020
slaskawi
force-pushed
the
KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster
branch
from
April 9, 2020 09:19
11efad6
to
2e223e6
Compare
slaskawi
force-pushed
the
KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster
branch
from
April 9, 2020 09:19
2e223e6
to
bd9b643
Compare
davidffrench
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @slaskawi
abstractj
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ID
KEYCLOAK-13743
Additional Information
This Pull Request fixes an error reported in operator-framework/community-operators#1479. The reason Travis failed in the Operatorhub was that
KeycloakBackup
CR was pointing to a non-existing Keycloak cluster.Verification Steps
Checklist:
Additional Notes