Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

KEYCLOAK-13743 Do not panic on missing Keycloak cluster #163

Conversation

slaskawi
Copy link
Contributor

@slaskawi slaskawi commented Apr 7, 2020

JIRA ID

KEYCLOAK-13743

Additional Information

This Pull Request fixes an error reported in operator-framework/community-operators#1479. The reason Travis failed in the Operatorhub was that KeycloakBackup CR was pointing to a non-existing Keycloak cluster.

Verification Steps

Checklist:

  • Verified by team member
  • Comments where necessary
  • Automated Tests
  • Documentation changes if necessary

Additional Notes

@slaskawi
Copy link
Contributor Author

slaskawi commented Apr 7, 2020

@JiyeYu @pb82 @davidffrench May I ask you for review?

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage increased (+0.1%) to 41.242% when pulling bd9b643 on slaskawi:KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster into 3519447 on keycloak:master.

Copy link
Contributor

@davidffrench davidffrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed now @slaskawi

pkg/controller/keycloakbackup/keycloakbackup_controller.go Outdated Show resolved Hide resolved
@slaskawi slaskawi added this to the 9.0.3 milestone Apr 9, 2020
@slaskawi slaskawi force-pushed the KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster branch from 0623602 to 11efad6 Compare April 9, 2020 09:00
@slaskawi
Copy link
Contributor Author

slaskawi commented Apr 9, 2020

@davidffrench Updated and re-pushed.

pkg/common/controller_utils_test.go Outdated Show resolved Hide resolved
pkg/common/controller_utils.go Outdated Show resolved Hide resolved
pkg/common/controller_utils_test.go Outdated Show resolved Hide resolved
@slaskawi slaskawi force-pushed the KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster branch from 11efad6 to 2e223e6 Compare April 9, 2020 09:19
@slaskawi slaskawi force-pushed the KEYCLOAK-13743-Do-not-panic-on-missing-Keycloak-cluster branch from 2e223e6 to bd9b643 Compare April 9, 2020 09:19
Copy link
Contributor

@davidffrench davidffrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @slaskawi

@abstractj abstractj self-requested a review April 9, 2020 13:42
@abstractj abstractj requested review from abstractj and removed request for abstractj April 9, 2020 13:42
@slaskawi slaskawi merged commit 08cfd84 into keycloak:master Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants