-
Notifications
You must be signed in to change notification settings - Fork 281
KEYCLOAK-13582 user federation provider and mapper #240
KEYCLOAK-13582 user federation provider and mapper #240
Conversation
This looks really good. But bind credential should probably be a secret ref. |
@kfox1111 Yes, I think so too, but there should be a unified way to do it. The samme problem already exists for example in clientSecret for an IdP. I briefly asked about it here:
But I think it should be done in another PR. I never got a response in KEYCLOAK-12677 - do you think we should create a new Jira issue for this (clientSecret, bindCredential etc) and discuss possible designs there? |
@chlunde Yes, that's a good point. All Secret refs should be somehow consistent across all our CRs. Could you please spin up a discussion on Keycloak DEV: https://groups.google.com/g/keycloak-dev ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chlunde I like the proposed change but the situation is exactly the same as in #230 (review)
@chlunde Since your previous PR has been merged, maybe we can get this one rolling? |
9a4d1db
to
232d1ca
Compare
232d1ca
to
0aed1e3
Compare
@slaskawi done |
Integrated, thanks @chlunde ! |
@slaskawi / @chlunde sorry to hijack this issue, I was unsure on where to best post this. |
@Chive We have a ticket for this - https://issues.redhat.com/browse/KEYCLOAK-13098. I think it's best to subscribe to it. Perhaps you'd be interested in contributing this feature? |
JIRA ID
https://issues.redhat.com/browse/KEYCLOAK-13582
Additional Information
Support for LDAP and customizing it using mappers.
This PR builds on other PRs, only the latest commit is relevant. I will rebase when the other commits are merged.
Verification Steps
The configuration has been e2e tested using an export (this ensures all field names are correct).
For a manual test:
Checklist: