Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

feat: Upgrade Postgres to 11.5 #73

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

davidffrench
Copy link
Contributor

@davidffrench davidffrench commented Nov 8, 2019

JIRA ID

KEYCLOAK-12259

Additional Information

Based on a mail thread, Postgres should be updated to 10.1 but this is not working with OpenShift due to permissions. It is working with 11.5 but we need confirmation we can upgrade to this.

Verification Steps

  1. Create Keycloak instance from this branch
  2. Run any other tests you think are required.

Checklist:

  • Verified by team member
  • Comments where necessary
  • Automated Tests
  • Documentation changes if necessary

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.017% when pulling ca9a795 on davidffrench:update_postgres into c92d00e on keycloak:master.

@davidffrench davidffrench marked this pull request as ready for review November 15, 2019 14:26
@slaskawi
Copy link
Contributor

Please do not merge it just now. I plan to test it out (with a few migration scenarios) today or tomorrow.

@stianst
Copy link
Contributor

stianst commented Nov 26, 2019

What level of testing do we have around DBs? We do really need to automate all testing and not require manual testing to update the DB version.

@slaskawi
Copy link
Contributor

I've tested this one locally and I guess it's fine to merge it. There's one thing to consider though - if you're upgrading existing operator installation - you might lose some data.

It seems when upgrading the Postgresql it wipes out everything from the DB. Once we upgrade Keycloak image (which will happen very soon), the migration addon will restart Keycloak and everything will eventually be populated to the DB. However, you will lose all manual modification you did. The only solution for that is to do a backup of your data prior to the upgrade.

@slaskawi
Copy link
Contributor

What level of testing do we have around DBs? We do really need to automate all testing and not require manual testing to update the DB version.

@stianst We got extremely unlucky with this one. Just before the initial release, we were told that the OpenShift Team is not planning to maintain Postgresql 9.5 in 4.x series. Even though that came as a surprise - we're using the community image, which is in perfect health. So this time we're lucky I guess but once the image gets productized, we need to work on automatic upgrades that include database version or type migration (basically KEYCLOAK-12027).

@slaskawi slaskawi merged commit fb19ff4 into keycloak:master Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants