Update the Keycloak SAML adapter subsystem to no longer use the AttributeDefinition#getAttributeMarshaller method

[fjuma]

Before reporting an issue

• I have searched existing issues
• I have reproduced the issue with the latest nightly release

Area

adapter/jee-saml

Describe the bug

The Keycloak SAML adapter subsystem currently references the AttributeDefinition#getAttributeMarshaller method that has been removed in WildFly Core 21.1.0.Final and later.

This means that attempting to use the keycloak-saml-adapter-galleon-pack with WildFly 29 and later results in the following exception when attempting to add subsystem resources:

 java.lang.NoSuchMethodError: 'org.jboss.as.controller.AttributeMarshaller org.jboss.as.controller.SimpleAttributeDefinition.getAttributeMarshaller()'
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeSps(KeycloakSubsystemParser.java:501)
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeSecureDeployment(KeycloakSubsystemParser.java:487)
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeContent(KeycloakSubsystemParser.java:474)

KeycloakSubsystemParser needs to be updated to make use of the AttributeDefinition#getMarshaller method instead.

Version

22.0.1

Expected behavior

It should be possible to successfully use the keycloak-saml-adapter-galleon-pack with WildFly 29 and later.

Actual behavior

It's currently not possible to use the keycloak-saml-adapter-galleon-pack with WildFly 29 and later when specifying the configuration required to secure SAML applications via the Keycloak SAML adapter subsystem.

How to Reproduce?

Using galleon.sh, attempt to provision a WildFly 29 server using the Keycloak SAML adapter feature pack:

galleon.sh install wildfly:current --layers=web-server,core-tools --dir=wildfly
galleon.sh install org.keycloak:keycloak-saml-adapter-galleon-pack:22.0.1 --layers=keycloak-client-saml --dir=wildfly

Execute the following WildFly CLI commands:

/subsystem=keycloak-saml/secure-deployment=saml-app.war:add()
/subsystem=keycloak-saml/secure-deployment=saml-app.war/SP=saml-app:add(sslPolicy=EXTERNAL)

The following error will occur:

 java.lang.NoSuchMethodError: 'org.jboss.as.controller.AttributeMarshaller org.jboss.as.controller.SimpleAttributeDefinition.getAttributeMarshaller()'
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeSps(KeycloakSubsystemParser.java:501)
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeSecureDeployment(KeycloakSubsystemParser.java:487)
at org.keycloak.keycloak-saml-wildfly-jakarta-subsystem@22.0.1//org.keycloak.subsystem.adapter.saml.extension.KeycloakSubsystemParser.writeContent(KeycloakSubsystemParser.java:474)

Anything else?

I will submit a PR to fix this.