Update the Keycloak SAML adapter subsystem to no longer use the AttributeDefinition#getAttributeMarshaller method #22594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjuma
force-pushed
the
issue22593
branch
3 times, most recently
from
11a77c0
to
51edca8
Compare
jfdenise
reviewed
Aug 22, 2023
| @@ -140,6 +140,11 @@ | |||
| <optional>true</optional> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
@fjuma , does this fix requires this new dependency with test scope?
There was a problem hiding this comment.
@jfdenise This new dependency was needed to get the Keycloak subsystem parsing tests to pass. It's not related to the underlying problem here. It seemed to be a separate issue that was causing the parsing tests to fail.
jfdenise
approved these changes
Aug 22, 2023
…buteDefinition#getAttributeMarshaller method Closes keycloak#22593
pedroigor
approved these changes
Aug 22, 2023
ghost
added
the
|
I've reviewed #22824 so am closing this PR now. Thanks! |
auto-merge was automatically disabled
August 30, 2023 17:00
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AttributeDefinition#getAttributeMarshallermethod has been removed in WildFly Core 21.1.0.Final and later.This PR makes it possible to use the
keycloak-saml-adapter-galleon-packwith WildFly 29 and later when using the Keycloak SAML adapter subsystem configuration to secure SAML applications.Closes #22593