Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EAP8 with SAML Adapter Galleon Feature Pack #22955

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

pskopek
Copy link
Contributor

@pskopek pskopek commented Sep 4, 2023

Dependencies used in SAML Adapter Galleon Feature Pack need to be aligned with EAP8.

Backport of #22824

@ghost
Copy link

ghost commented Sep 4, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testReauthenticationSamlBrokerWithOTPRequired

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.AssertionError: Expected LoginConfigTotpPage but was Sign in to provider (https://localhost:8543/auth/realms/provider/login-actions/authenticate?client_id=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fconsumer&tab_id=fnoM3f_WUU0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LogoutSessionsPage.assertCurrent(LogoutSessionsPage.java:36)
...

Report flaky test

org.keycloak.testsuite.model.user.UserSyncTest#testManyUsersImport

Keycloak CI - Store Model Tests

org.keycloak.models.ModelException: org.keycloak.models.ModelException: Error creating subcontext [uid=user1,ou=People,dc=keycloak,dc=org]
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
...

Report flaky test

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

pskopek and others added 6 commits September 7, 2023 13:56
Signed-off-by: Peter Skopek <pskopek@redhat.com>
(cherry picked from commit ef272f7)
(cherry picked from commit 7aec003)
…buteDefinition#getAttributeMarshaller method

Closes keycloak#22593

Signed-off-by: Peter Skopek <pskopek@redhat.com>
(cherry picked from commit ec08a7b)
Signed-off-by: Peter Skopek <pskopek@redhat.com>
(cherry picked from commit bca5fe8)
…dules

Signed-off-by: Peter Skopek <pskopek@redhat.com>
(cherry picked from commit 35c2d52)
@ahus1 ahus1 merged commit e879367 into keycloak:release/22.0 Sep 7, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants