-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EE #671
Add EE #671
Conversation
I'd like to only enforce licensing in non-test environments. That will make tests easier to run (i.e. we won't have to add a test license to CI). Alternatively, we could set up |
Meh. Maybe later. |
A consequence of making event logs an EE feature: the triggers for the expiration basis, so all but |
5bc9a6c
to
49dfe01
Compare
Meh. I don't like having Pro vs EE. Let's just stick to CE and EE. |
The real reason I feel weird about the event logs being EE is that it removes the expiration basis behavior from CE, which is utilized by a sizeable percentage of Keygen users. We should decouple event notification from event logging. We’ll need to rework our event notification system to emit events, but not rely on event logs. |
ed84cc8
to
7c7a83a
Compare
Accessing event and request logs, and setting permissions via the console should fail in CE. Maybe look at 1984 and see if there are hooks we can use for detecting if we’re in a console session. |
@@ -0,0 +1,38 @@ | |||
# frozen_string_literal: true | |||
|
|||
# FIXME(ezekg) Rename to EventNotificationWorker once old jobs are processed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to rename to EventNotificationWorker
after deploy
35d9675
to
0b05a74
Compare
18129ee
to
3655fa4
Compare
Need to write tests for EE licensing classes. |
effe707
to
3619917
Compare
49dfe98
to
2d5b6d4
Compare
- this would cache the lic and cause tests to break
bab4342
to
80574fb
Compare
80574fb
to
fb6c60a
Compare
c95f073
to
863ea77
Compare
Part of #644. Adds an Enterprise Edition, with licensing for the following Keygen EE features:
Making these EE features not only pushes the right market segment towards EE, but it improves performance for CE, since requests logs and event logs are high-throughput and require quite a bit of extra storage.
Before deploy
After deploy
EventNotificationWorker2
toEventNotificationWorker
.